WIP: drivers: creates independent module for importing driver interface#27623
Draft
mismithhisler wants to merge 1 commit intomainfrom
Draft
WIP: drivers: creates independent module for importing driver interface#27623mismithhisler wants to merge 1 commit intomainfrom
mismithhisler wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes are a first stage for moving the plugins package into it's own go module. The motivation for these changes was to decouple plugin dependencies from Nomad client/server dependencies. As an example, this is important for container task drivers which import the container runtime spec. Nomad uses a version of the container runtime spec for it's exec tasks, which may be different from runtime spec needed for a task driver. This has the potential to cause version conflicts (and did recently with Podman).
By removing Nomad imports from the plugins module, driver authors will see less package conflicts, making it easier to author Nomad drivers.
There are still a number of tasks to accomplish before this migration is complete. They include:
and imported from plugin-interface.
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.